James Milner

Seems like Mapbox Draw explicitly swallows these events: https://github.com/mapbox/mapbox-gl-draw/blob/2b9ce3e58e3695c018a48b6fca78ed1a9d1b67c2/src/events.js#L127

Thinking about this a bit more I've figued out what's going on. The following line: https://github.com/mapbox/mapbox-gl-draw/blob/2b9ce3e58e3695c018a48b6fca78ed1a9d1b67c2/src/events.js#L132 Checks if `ctx.options.controls.trash` is true and then funnels it to `onTrash`. When you're writing...

This sounds like it would be a great improvement to the library :+1: What would the next steps look like do you think? I may be able to help here...

Hi @nicolocarpignoli thanks for the issue. I haven't looked into this, as it was difficult enough getting things working and refactoring the codebase. If the NFT branch if artoolkit can...

@kalwalt that's super cool! One thing we'd need to do is compile a new version of jsartoolkit for the project and test that it doesn't break any of the current...

Using the Chrome coverage tool might be useful here: https://www.vojtechruzicka.com/measuring-javascript-and-css-coverage-with-google-chrome-developer-tools/

Hi @marcvoegele In honesty my current understanding is that it doesn't. However, the converted code from AR.js https://github.com/JamesLMilner/THREEAR/blob/799d17c08416e49fbf6ee04da6d47e182124f991/src/artoolkit/ARToolKitController.ts#L208 seems to contain references to the multimarker functionality, but I never actually...

I noticed @nicolocarpignoli released https://github.com/nicolocarpignoli/GeoAR.js. I wonder if it would be possible to compile this into the library and expose it with our API for Three.js? Unfortunately I don't have...

Hi @stephanedemotte, I can potentially look into this when I have some bandwidth but I'm a bit tied up a the moment. Feel free to raise a pull request if...

I had a little go at tackling this today, but it seems tricky as there's no sensible way to remove the marker on the artoolkit side of things. I would...