THREEAR icon indicating copy to clipboard operation
THREEAR copied to clipboard

Disable aspect ratio

Open stephanedemotte opened this issue 5 years ago • 2 comments

Hello.

We need to put video into the canvas to take a screenshot via canvas.toDataUrl('png')

For anyone we simply scene.background = new THREE.VideoTexture(source.domElement)

But when we shoot the canvas, the width and height is is the same than what we see. You use a bigger canvas than the screen, and re-center it with margin-left or margin-top.

Can you add a param to disable the keep aspect ratio ?

Thanks again for this great work !

stephanedemotte avatar Mar 22 '19 19:03 stephanedemotte

@stephanedemotte I'm guessing this is to do with the way in which the webcam source sets the objectFit property for its HTMLVideoElement: https://github.com/JamesMilnerUK/THREEAR/blob/master/src/Source.ts#L303

Does that sound right to you? I'm not entirely sure how to provide the parameter you're asking for or how to make it work for your use case so any code samples or deeper explanation would be helpful.

JamesLMilner avatar Mar 22 '19 21:03 JamesLMilner

Sorry @JamesMilnerUK my english suck, i will try to be more clear

In https://github.com/JamesMilnerUK/THREEAR/blob/master/src/Source.ts#L201 In the onResizeElement function you make the canvas bigger than the window, then you center with martin-left or margin-top, is it possible to keep the canvas the same size as the window?

@JamesMilnerUK ping!

stephanedemotte avatar Mar 26 '19 21:03 stephanedemotte