dialogs icon indicating copy to clipboard operation
dialogs copied to clipboard

Places assets inline, rather than relying on fs?

Open jonathon-love opened this issue 3 years ago • 0 comments

hi,

we've used dialogs for some time, but we're in the process of updating our toolchain to use vite rather than browserify. it seems that browserify (or is it babel?) made it really easy to sub dialogs' calls to fs.readFileSync() ... however i don't think this is so straightforward with modern tools like vite.

what do you think about replacing the fs.readFileSync() calls in dialogs with inlined resources?

it is a bit funny that dialogs makes use of both fs.readFileSync() and document.appendChild() meaning in it's unprocessed form, it can't run in the browser, or in node.

with thanks

jonathon-love avatar Nov 09 '22 04:11 jonathon-love