James Henry

Results 506 comments of James Henry

We seem to have an old node types reference in our package.json -> `"@types/node": "18.19.8",` - I think that could be dragging in old typings (I'm basing that on the...

Actually it seems the issue with the old typings is already resolved: https://www.npmjs.com/package/nx/v/19.1.1?activeTab=code I opened a node 20 typings PR just in case we want that but feel free to...

@ianwremmel Please kindly provide a minimal reproduction of the issue on a fresh workspace. It's clearly a lot more than just us that is not experiencing this issue (otherwise there...

Closing this one as it was fixed a while ago, thanks again @KeithYeh!

@joh-klein I see you forked the action and added this functionality for yourself. Would you like to open a PR back to this repo and we can get it added?...

I would please also include an example of your use-case in the README and why you might want to ever override this property

Ha, so this did indeed fix v20, but has caused v18 to fail... I will see if I can repro locally. Perhaps it just needs a few retries on the...

It turns out `global.gc` does not exist by default in Node 18. We could either: - skip the tests in Node 18 - always run node explicitly for the mocha...

~~NOTE: This will still be blocked until the type error on latest TS is resolved~~ Fixed in commit https://github.com/ReactiveX/rxjs/pull/7512/commits/72884e22b93aab8e58e12e2e8b90d24748f469c0

Thanks @ansjllenasm would you be able to open a PR for this?