summarize_covariance not working

[pdolder]

VAST::Summarize_Covariance has moved to FishStatsUtils::summarize_covariance, but that function still calls VAST:::calc_cov, which is not longer there.

Think its a simple change to FishStatsUtils::calc_cov here: https://github.com/James-Thorson-NOAA/FishStatsUtils/blob/7f24b959290014537f84545b321b9e69966fc10e/R/summarize_covariance.R#L104

[James-Thorson-NOAA]

Are you willing to test that the function works with this fix, and do a pull request?

[pdolder]

Sure, will do.

On Fri, 7 Feb 2020 at 15:40, Jim Thorson [email protected] wrote:

Are you willing to test that the function works with this fix, and do a pull request?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/James-Thorson-NOAA/VAST/issues/217?email_source=notifications&email_token=AC4F4SL6LDLO4A33IHBD3LDRBV6GLA5CNFSM4KRQO7KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELDN74I#issuecomment-583458801, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4F4SLEFYYJGYWZIICKSMTRBV6GLANCNFSM4KRQO7KA .

[jin-gao]

The 1st approach gives error calc_cov is not an exported object from 'namespace:FishStatsUtils'

Redefined calc_cov separately solved the problem.