Jalil Arfaoui

Results 98 comments of Jalil Arfaoui

Hello @AlexGilleran I agree it is a matter of opinion if we should or not have an explicit boolean cast in conditions. Except that I think, like @colshacol, that we...

Maybe you could add `yarn.lock` or `package-lock.json` ?

(And thanks for this, first of all :-) )

Hello I would like that too. Example of simple use case : - Previous Webpack conf was building files in `css/1.css`, `css/2.css`, ... - Changed `css ` to `style` in...

I think it should `return next(action)`, not `return action`

What difference do you have in mind between `minified.js` and `redux-polyglot.min.js` ?

As we discussed, I'd personally prefer that translate can be called either : - `translate(MyComponent)` - `translate('some.polyglot.scope', MyComponent)` - `translate('some.polyglot.scope')(MyComponent)` Why would you want to forbid the first one ?

Mmm .. why not. And do we still consider this usage : `translate({ polyglotScope: 'some.polyglot.scope' })(MyComponent)` or, in other words : `translate(options)(MyComponent)` ? It seems more complicated, but it enables...

One more thing ... maybe we could choose between - `translate('scope', MyComponent)` - `translate('scope')(MyComponent)` If we want to maintain both, and keep using curry, to handle this call : `translate()(MyComponent)`...