Jacob Smith

FYI we're considering replacing fetch_module with fetch

The current design puts all loaders in the same worker thread (eg there are a total of 2 threads: the main and the worker). Internal things are handled via the...

Something in this implementation is causing node to hang on startup. We suspect it's some kind of circular dependency, and the subsequent dependency smacks into the Atomics lock (preventing the...

I found the circular dep: `process/esm_loader.js:12` ← `modules/esm/public_loader_proxy.js:3` ← `worker_thread.js:29/36` ← `process/pre_execution.js:562` ← `process/esm_loader.js`

Gah, it wasn't a circular dependency 🤦‍♂️ it was setting `url` to `null` here: https://github.com/nodejs/node/blob/9836c67198b2d01350f283e10b872849e81abefa/lib/internal/worker.js#L141-L149 which caused the worker to spawn with nothing in it. (I shouldn't have copied it...

I'm currently investigating the V8 / C++ error thrown when the Worker is instantiated: ``` node:internal/worker:202 this[kHandle] = new WorkerImpl(url, ^ This Environment was initialized without a V8::Inspector Thrown at:...

> Adding a “request changes” here to see https://github.com/nodejs/node/issues/43658#issuecomment-1288170130 resolved. It might be a little premature to drop a block: The loaders team (what're we called now?) also want the...

I definitely don't know the arcane inner workings of git, and I couldn't tell you how or why it would or wouldn't work. But I have anecdotally confirmed this particular...

@Trott It looks like I can't from GitHub mobile. You're welcome to hide mine if you'd like (otherwise I'll do in a couple weeks when I'm back home). PS Yes...

Meantime, for those looking for a workaround, this is possible with a combination of stub.get/set + spy: [#1545 comment-385262212](https://github.com/sinonjs/sinon/issues/1545#issuecomment-385262212)