bms-parser icon indicating copy to clipboard operation
bms-parser copied to clipboard

Published 20 hours ago • verified publisher icon Jakeler

Upstreaming to kaitai_struct_formats

Open KOLANICH opened this issue 4 years ago • 5 comments
trafficstars

https://github.com/kaitai-io/kaitai_struct_formats/

KOLANICH avatar Jan 24 '21 08:01 KOLANICH

Yes, I think that is a good idea. Though I am not sure in which category/folder it would fit and under what name. Is bms_protocol or battery_management_system clear enough? How would you call and categorize it? @KOLANICH

Jakeler avatar Jan 24 '21 19:01 Jakeler

  1. we have a cathegory hardware
  2. I have plans to bring some specs related to Smart Battery. So we need a battery/bms dir.
  3. Since there is no namespaces (all generated files are placed flatly) currently, the specs names should be global. So I guess hardware/battery/bms/battery_management_system_protocol.ksy

KOLANICH avatar Jan 24 '21 20:01 KOLANICH

Thanks, see: https://github.com/kaitai-io/kaitai_struct_formats/pull/410

Jakeler avatar Jan 31 '21 13:01 Jakeler

Hye just wanted to ask, already ask at your email. how do you connect the bms? are you using the bluetooth or the uart usb?

eiman5899 avatar May 29 '22 17:05 eiman5899

@eiman5899 Does not relly make a difference as the script just reads/writes to a device file. Can be either a direct cable connection with an UART/USB adapter. Or wirelessly connected 2 bluetooth module ending again in the UART adapter. Or (what I always use these days) direct wireless connection to the bluetooth dongle on the bms with ble-serial, it provides a virtual serial port /tmp/ttyBLE which can be used like a real one.

Jakeler avatar May 30 '22 18:05 Jakeler