picasso2-okhttp3-downloader
picasso2-okhttp3-downloader copied to clipboard
JakeWharton
Deprecate library or provide information
Since Picasso 2.71828 has built-in OkHttp3Downloader I would suggest to deprecate this library as the built-in downloader should now be used.
Alternatively, it would be helpful to at least provide some informations about new built-in downloader in README, to help people understand why they might be facing some problems after updating their Picasso version to 2.71828 (while still using this library). This could also prevent people from opening another issues like #28, #29, #30
We aren't really advertising Picasso 2.71828 since it's a breaking change from 2.5.2. So for now, the library still has use for users of 2.5.x and earlier. It will be deprecated if 3.0 gets released.
On Mon, May 7, 2018 at 1:24 PM Michał Baran [email protected] wrote:
Since Picasso 2.71828 has built in OkHttp3Downloader I would suggest to deprecate this library as the built in downloader should now be used. Alternatively, it would be helpful to at least provide some informations about new built in downloader in README, to help people understand why they might be facing some problems after updating their Picasso version to 2.71828 (while still using this library). This could also prevent people from opening another issues like #28 https://github.com/JakeWharton/picasso2-okhttp3-downloader/issues/28, #29 https://github.com/JakeWharton/picasso2-okhttp3-downloader/issues/29, #30 https://github.com/JakeWharton/picasso2-okhttp3-downloader/issues/30
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/picasso2-okhttp3-downloader/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEaE5jP5iaErWOcHiA67UEOYKImeuks5twK2PgaJpZM4T1lc3 .
Maybe just a note on the main readme that if you are using Picasso version 2.7x or newer you don't need this library but should use instead the picasso build-in downloader. Thanks!
I'd agree with @zoltanf. A quick note in the README will fix lots of confusion. I upgraded Picasso to 2.71828, but did not switch to the new version of OkHttp3Downloader, and my images stopped loading and I didn't get any real useful error messages in my logs, even after enabling logging on my Picasso instance. Switching to the new version that comes with Picasso fixed it immediately.
