docker-gphotos-sync icon indicating copy to clipboard operation
docker-gphotos-sync copied to clipboard

Suggestion - Change Forks

Open latetedemelon opened this issue 1 year ago • 4 comments

It would appear that this fork:

https://github.com/msfjarvis/gphotos-cdp

Is better maintained; it may be advantageous to pull from there as opposed to the original repository.

latetedemelon avatar Dec 11 '24 01:12 latetedemelon

So it looks like the only two real commits added were

  • https://github.com/msfjarvis/gphotos-cdp/commit/5a8e638306804016cb5d2b78c7549775c44dc963
  • https://github.com/msfjarvis/gphotos-cdp/commit/bfd6827e93ff974b5e3aa473966cd1a469eaaf24

Otherwise it's a bunch of Nix noise.

I guess there's no harm in changing, although I will say that I haven't had any problems with the existing setup. I mostly just leave it alone on my personal deployment.

JakeWharton avatar Dec 11 '24 03:12 JakeWharton

@latetedemelon I suggest this one instead: https://github.com/spraot/gphotos-cdp

The changes include:

  • Update cdp dependencies
  • Make finding end of library more robust
  • If downloaded file is a zip, unzip it
  • Add -date option that takes the date from the gphotos UI and sets it as file modified time (many of my files have no date metadata)
  • Fix some issues I had with authentication

I'd be happy to accept a PR if it solves any other issues

I use that one in my version of gphotos-sync

spraot avatar Jan 14 '25 12:01 spraot

I never managed to get this to work on my server and ended up rewriting the docker code and using a version of gphotos-cdp with a bunch of my fixes and improvements: https://github.com/spraot/gphotos-sync

It uses chrome instead of chromium and that only seems to work on amd64 platforms. But otherwise there's a bunch of nice improvements and fixes relative to this one. Besides the above I fixed a race condition that was killing my sync every 50 files or so, json logging, the ability to recheck for older files by deleting ".lastdone" (and skipping already downloaded files), and maybe other stuff I forgot.

spraot avatar Jan 20 '25 13:01 spraot

I'll attempt to give it a try in the coming weeks. I'm not married to maintaining this and happy to redirect people your way!

JakeWharton avatar Jan 21 '25 02:01 JakeWharton