dagger-reflect icon indicating copy to clipboard operation
dagger-reflect copied to clipboard

Circular module dependency

Open Dkhusainov opened this issue 4 years ago • 0 comments

dagger-compiler: 2.27 dagger-reflect: 0.2.0

dagger-compiler allows circular module dependencies(which is wrong, should be an error), while dagger-reflect hangs forever while trying to build Component with such modules.

Reproduce:

package test

@dagger.Component(modules = [Module1::class])
interface Component

@dagger.Module(includes = [Module2::class])
abstract class Module1

@dagger.Module(includes = [Module1::class])
abstract class Module2

class Test {
  @org.junit.Test
  fun test() {
    //dagger-compiler is silent on circular dependencies
//    DaggerComponent.create()

    //dagger-reflect hangs on infinite loop
    dagger.Dagger.create(test.Component::class.java)
  }
}

Dkhusainov avatar Jun 10 '20 10:06 Dkhusainov