dagger-reflect
dagger-reflect copied to clipboard
JakeWharton
Fill in README.md
Copied from butterknife-reflect as a baseline.
Added both usages, Kotlin to be done after it's implemented.
dagger-android to be discovered
preview available at https://github.com/TWiStErRob/dagger-reflect/tree/usage
Could you also document what the limitations currently are, meaning what of dagger is not supported yet?
If only I knew, I guess https://github.com/JakeWharton/dagger-reflect/search?q=notImplemented&unscoped_q=notImplemented is a good starting point (sadly it doesn't show all occurrences, only 1 for each file). I wouldn't put it in the README as a list though, just a link like above.
@JakeWharton any thoughts on having a GH milestone with issues for each missing feature?
@JakeWharton is there any reason to not merge this? Do I need to do something here?
I haven't read it yet. I assume it helps people use the library? I don't want people using it yet.
On Thu, Feb 14, 2019 at 3:26 PM Róbert Papp (TWiStErRob) < [email protected]> wrote:
@JakeWharton https://github.com/JakeWharton is there any reason to not merge this? Do I need to do something here?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/JakeWharton/dagger-reflect/pull/12#issuecomment-463781528, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEQHrHYNvhhvrJk99k6yckZxtm4WNks5vNcaOgaJpZM4agcdq .
Then merge it and add a disclaimer: "Do not use this".
It's helpful for people taking a look at it and who are experimenting.
I just said that I don't want you to and I have no interest in helping you do so at this time.