byteunits icon indicating copy to clipboard operation
byteunits copied to clipboard

Move BinaryByteUnitTest into commonMain with preliminary iOS support.

Open vanniktech opened this issue 2 years ago • 10 comments

References #10

Is this how you'd want to do the enum dance? https://github.com/JakeWharton/byteunits/issues/10#issuecomment-1183892402

If so, I can continue with the others.

vanniktech avatar Jan 24 '23 10:01 vanniktech

Do we need something so that the CI works?

Could not read standard output of command '/usr/bin/xcrun'.
java.lang.NoSuchMethodError: 'void org.gradle.api.internal.tasks.testing.TestResultProcessor.failure(java.lang.Object, java.lang.Throwable)'

	at org.jetbrains.kotlin.gradle.internal.testing.TCServiceMessagesClient.failure(TCServiceMessagesClient.kt:176)
> Task :iosX64Test FAILED
	at org.jetbrains.kotlin.gradle.internal.testing.TCServiceMessagesClient.serviceMessage(TCServiceMessagesClient.kt:78)

	at jetbrains.buildServer.messages.serviceMessages.ServiceMessagesParser.parse(ServiceMessagesParser.java:54)
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
	at jetbrains.buildServer.messages.serviceMessages.ServiceMessage.parse(ServiceMessage.java:121)

	at org.jetbrains.kotlin.gradle.internal.testing.TCServiceMessageOutputStreamHandler.parse(TCServiceMessageOutputStreamHandler.kt:121)
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
	at org.jetbrains.kotlin.gradle.internal.testing.TCServiceMessageOutputStreamHandler.flushLine(TCServiceMessageOutputStreamHandler.kt:81)

	at org.jetbrains.kotlin.gradle.internal.testing.TCServiceMessageOutputStreamHandler.write(TCServiceMessageOutputStreamHandler.kt:61)
See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
	at org.gradle.process.internal.streams.ExecOutputHandleRunner.forwardContent(ExecOutputHandleRunner.java:[67](https://github.com/JakeWharton/byteunits/actions/runs/3995904568/jobs/6855316461#step:5:68))
	at org.gradle.process.internal.streams.ExecOutputHandleRunner.run(ExecOutputHandleRunner.java:53)
	at org.gradle.internal.operations.CurrentBuildOperationPreservingRunnable.run(CurrentBuildOperationPreservingRunnable.java:42)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:[82](https://github.com/JakeWharton/byteunits/actions/runs/3995904568/jobs/6855316461#step:5:83)9)
22 actionable tasks: 22 executed

vanniktech avatar Jan 24 '23 12:01 vanniktech

Downgrade to Gradle 7.5 or upgrade to Kotlin 1.8.

JakeWharton avatar Jan 25 '23 04:01 JakeWharton

Crazy week. I'll look soon.

JakeWharton avatar Jan 25 '23 04:01 JakeWharton

Okay renovate is on so a bunch of things got updated. Repo is on Kotlin 1.8 and Gradle 7.6 now so rebase and all should be good.

JakeWharton avatar Jan 25 '23 04:01 JakeWharton

@JakeWharton this is finally green now.

vanniktech avatar Jan 26 '23 22:01 vanniktech

@JakeWharton had some spare time and finished everything. The repo is now multiplatform with ios & jvm targets. Also adjusted all the tests.

vanniktech avatar Feb 04 '23 10:02 vanniktech

I'm on paternity leave in a week and will have more time to look. Kinda. Less work distraction, more like.

JakeWharton avatar Feb 04 '23 17:02 JakeWharton

No rush. I've published this myself: com.vanniktech:byteunits:0.11.0 so I can start using it in production.

vanniktech avatar Feb 05 '23 10:02 vanniktech

Resolved the conflicts.

vanniktech avatar Mar 26 '23 14:03 vanniktech

@JakeWharton friendly ping

vanniktech avatar Jun 03 '23 18:06 vanniktech