butterknife icon indicating copy to clipboard operation
butterknife copied to clipboard

Color tint support for @BindDrawable

Open sp00ne opened this issue 8 years ago • 2 comments

Hi there Jake!

I'm a great fan of your work :) Something that I noticed was the need for color resource support in the tinting of drawables, the pull request adds @ColorRes annotation for the tint binding and makes the necessary changes to the code for it to work. I expanded the sample activity to include an ImageView that is tinted in this manner.

I hope this meets your standards.

Best regards, Mohsen Farzone

sp00ne avatar Jun 15 '17 11:06 sp00ne

I'm not sure that I want to conflate this attribute with two meanings. Is there a reason you don't want to define the color you're tinting with on the theme?

JakeWharton avatar Jun 15 '17 14:06 JakeWharton

Yeah, in most cases where I work (especially larger projects) the colors are not associated with the theme or there is a situational basis for the coloring

sp00ne avatar Jun 16 '17 08:06 sp00ne