memory leak: shareTargetSelectedListener reference stays forever

[veonua]

actionProvider.setOnShareTargetSelectedListener(shareTargetSelectedListener);
actionProvider.setOnShareTargetSelectedListener(null);

the shareTargetSelectedListener stays forever, and could not be nulled, because of

/**
 * Set the activity chooser policy of the model backed by the current
 * share history file if needed which is if there is a registered callback.
 */
private void setActivityChooserPolicyIfNeeded() {
    if (mOnShareTargetSelectedListener == null) { // << this line
        return;
    }
    if (mOnChooseActivityListener == null) {
        mOnChooseActivityListener = new ShareAcitivityChooserModelPolicy();
    }
    ActivityChooserModel dataModel = ActivityChooserModel.get(mContext, mShareHistoryFileName);
    dataModel.setOnChooseActivityListener(mOnChooseActivityListener);
}

also ActivityChooserModels are static, so shareTargetSelectedListener stays while the application working, this is a huge memory leak (in my case shareTargetSelectedListener needs a context and locks the whole activity in memory)

[SimonVT]

I don't see how that line means shareTargetSelectedListener can't be nulled. It's nulled in setOnShareTargetSelectedListener.

[veonua]

as far as I can see -

ActivityChooserModel keeps all model policies, when we create a ShareAcitivityChooserModelPolicy it keeps whole ShareActionProvider as $.this, and keeps mOnShareTargetSelectedListener as the reference to the fragment (my case).

---

I discovered this bug in situation when I have couple of fragments (attached to different activities), both have a ShareActionProvider (with default history filename) in ActionBar, but in FragmentA I have setOnShareTargetSelectedListener(this)

I noticed click on the Share button on ActivityB fires FragmentA.onShareTargetSelected() (which should be destroyed when ActivityA stops), - reason ActivityChooserModel.get returns the reference to the Policy that keeps FragmentA.

On Wed, Apr 24, 2013 at 5:58 PM, Simon Vig Therkildsen [email protected] wrote:

I don't see how that line means shareTargetSelectedListener can't be nulled. It's nulled in setOnShareTargetSelectedListener.

— Reply to this email directly or view it on GitHub.

[SimonVT]

mOnShareTargetSelectedListener is nulled when you call setOnShareTargetSelectedListener(null)

[veonua]

ok, when should I null it? Should I null it manually?

On Wed, Apr 24, 2013 at 6:23 PM, Simon Vig Therkildsen < [email protected]> wrote:

mOnShareTargetSelectedListener is nulled when you call setOnShareTargetSelectedListener(null)

— Reply to this email directly or view it on GitHubhttps://github.com/JakeWharton/ActionBarSherlock/issues/913#issuecomment-16938398 .

[SimonVT]

I don't know, I haven't used ShareActionProvider. It works just like the one provided by the framework, so you should ask on stackoverflow or the android developers mailing list.

[veonua]

unfortunately, could reproduce using framework ShareActionProvider. it's suck =(((

[JakeWharton]

We've gotten in the habit of just writing our own with a more sane behavior and code using the same concept.

[veonua]

if you interested https://gist.github.com/veonua/5454621 sample code that reproduces the bug

On Wed, Apr 24, 2013 at 9:54 PM, Jake Wharton [email protected]:

We've gotten in the habit of just writing our own with a more sane behavior and code using the same concept.

— Reply to this email directly or view it on GitHubhttps://github.com/JakeWharton/ActionBarSherlock/issues/913#issuecomment-16956888 .