react-fastclick icon indicating copy to clipboard operation
react-fastclick copied to clipboard

Checkbox label is not working, when i use react-fastclick?

Open Aravindraj92 opened this issue 5 years ago • 6 comments

here my code==>

                           <input 
                            type="checkbox" 
                            className="no-fastclick checkbox" id="accept"
                            name="agree"
                            checked={this.state.checkBox}
                            onChange={this.handleCheck}/>
                            <label htmlFor="accept">By proceeding you agree to Terms of Use and Privacy Policy.</label>

Aravindraj92 avatar Jun 20 '19 07:06 Aravindraj92

Hello. Which version of react-fastclick are you using?

JakeSidSmith avatar Jun 20 '19 08:06 JakeSidSmith

Sorry for the late replay and I have using react-fastclick": "^3.0.2

Aravindraj92 avatar Jun 25 '19 05:06 Aravindraj92

Hey, @Aravindraj92. This seems to be something I never implemented. I'd be happy to accept a pull request to handle this. Inside this if block you'd simply need to check if the element type was a checkbox, and then set forTarget.checked = !forTarget.checked;.

If you'd like to look into this, it may be worth doing the same for radio buttons also. 😊

JakeSidSmith avatar Jun 25 '19 09:06 JakeSidSmith

Working! when modifying index.js in node module, but I couldn't modify there because I have run "npm install" in the server for every push request.

Aravindraj92 avatar Jun 25 '19 10:06 Aravindraj92

Hi, this problem has not resolve yet ?

Lizitao610 avatar Jun 11 '20 08:06 Lizitao610

It is not, though I'm happy to accept pull requests. 🙂

JakeSidSmith avatar Jun 11 '20 08:06 JakeSidSmith