react-images-upload icon indicating copy to clipboard operation
react-images-upload copied to clipboard

withPreview attribute defaults to false

Open yehee opened this issue 5 years ago • 2 comments

Hi! I've used this package for my React project and it's been great! I was wondering if there is a reason behind having withPreview attribute defaults to false. When I initially started using it, the image preview was not showing as mentioned in #48. I realized that the attribute needs to be set to true in order for it to work after stumbling upon that issue.

Here is where its default gets set to false. Would it make sense that this value is set to true instead? If there has been a discussion over such topic already, I'd love to read about it as well. Thank you!

yehee avatar Jun 16 '20 23:06 yehee

Not sure it's really been discussed before. Does anyone feel strongly about this?

JakeHartnell avatar Jun 17 '20 17:06 JakeHartnell

I can't imagine a lot of people want withPreview to be false because the user doesn't get feedback about the image being uploaded or not. I'd say it should default to true

verluci avatar Jun 25 '20 13:06 verluci