HypothesisReader icon indicating copy to clipboard operation
HypothesisReader copied to clipboard

TypeError: renderer.render.window.hypothesisInstall is not a function

Open BigBlueHat opened this issue 10 years ago • 2 comments

In: https://github.com/JakeHartnell/HypothesisReader/blob/master/js/hypothesisHook.js#L88

BigBlueHat avatar Nov 03 '15 15:11 BigBlueHat

Possibly related.

annotator-highlights-always-on class constantly gets adding/removing from body

It makes the eye icon flash on and off and if you bring up the DOM view in the inspector the class is being added and removed constantly...

This started happening after I browsed to the next page from the title page.

However, on Shift+Reloading, it seems to be gone...

BigBlueHat avatar Nov 03 '15 15:11 BigBlueHat

Hrm...might be a conflict with paging in Firefox (which, btw is what I'm mostly testing with atm).

Here's a screenshot of the scenario--which I recreated by loading it in a private session--otherwise the "current page" cookie info (I'm guessing) is Doing The Right Thing and avoiding this "launch" related bug.

2015-11-03 10_09_33-moby-dick herman melville

Steps to repeat:

  1. Load http://jakehartnell.github.io/HypothesisReader/
  2. open browser's page Console
  3. click "next page" icon
  4. click "next page" icon again
  5. see empty pages (in screenshot) and JS error

Reloading the page "fixed" the problem...not sure what's up, but may not be related to this code...hard to tell.

BigBlueHat avatar Nov 03 '15 15:11 BigBlueHat