swiftui-image-viewer icon indicating copy to clipboard operation
swiftui-image-viewer copied to clipboard

Does it support to swipe to the next or pre image?

Open csjryt opened this issue 4 years ago • 7 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Additional context Add any other context or screenshots about the feature request here.

csjryt avatar Dec 28 '20 07:12 csjryt

Currently it supports online one image at a time, but adding support for albums/multiple images is on the roadmap.

Jake-Short avatar Dec 28 '20 23:12 Jake-Short

Hi, does it support albums now?

buluoray avatar Mar 07 '21 07:03 buluoray

@buluoray The feature is currently being developed on the image-album-support branch. It is very buggy right now so I would wait to use it quite yet, but that branch is where you can check out the development.

Jake-Short avatar Mar 07 '21 08:03 Jake-Short

@Jake-Short Thanks! I checked it out. I do wish we can have something like an environmentObject to assign the images anywhere in the app to the imageViewer because I won't know what to assign at the NavigationView level but at the child views

buluoray avatar Mar 07 '21 22:03 buluoray

@buluoray For now, would it be possible to have an environmentObject at the root? Then you could use it for the NavigationView and could change/update it from all of the child views.

Jake-Short avatar Mar 07 '21 23:03 Jake-Short

Hey Jake I checked out your image album branch. One thing that stood out to me is your use of a GeometryReader. Because this is a framework you might run into a Reader within a Reader. We have had all kinds of problems with GeometryReaders inside of GeometryReaders. You say it is buggy, I would try refactoring the GeometryReader out and require passing in whatever geometry you need. Just a suggestion...

neodave avatar Aug 02 '21 22:08 neodave

@neodave That makes sense, thanks for taking a look! I will take your advice and try to do it without the GeometryReader.

Jake-Short avatar Aug 03 '21 02:08 Jake-Short