Jake Shadle

Results 189 comments of Jake Shadle

Windows builds are uninteresting for this project since this was made specifically for cross compilation on non-windows hosts, so I'm disinclined to add a windows release build. That being said,...

This _could_ be fixed, but I am disinclined to do that because what you attempting to do is not a good idea. You are trying to use a source file...

Ahh, apologies, I thought I saw your profile in the contributors list but maybe I just imagined that. 1. This is because, currently, only files that have `license/LICENSE` in their...

The defaults were chose as warn basically because: 1. `unsound` advisories are informational and distinct from vulnerabilities, with a lower priority and thus a lower level. 2. People already complain...

I'd accept a patch for this because I know the handling is incorrect for pre-releases, but they are also annoying and relatively rare so it's IMO low priority.

The output (or rather, the inputs to the template) is definitely supposed to be deterministic, so any PR fixing non-determinism would be welcomed.

Is that actually official now? I should have closed this regardless, most projects that have asm also have a GAS version for `windows-pc-gnu` so needing to cross compile masm is...

Now that cargo supports [workspace inheritance](https://doc.rust-lang.org/cargo/reference/workspaces.html#the-dependencies-table) I think the addition of this feature becomes much less interesting, I guess it could still be useful in some cases, but not enough...

That flag is meaningless https://github.com/protocolbuffers/protobuf/blob/55177c3574ce2718acf3d91cfcfbe9d035a6836d/src/google/protobuf/compiler/command_line_interface.cc#L1854-L1855