Jaifroid
Jaifroid
I'm not sure if this is still current, needs testing, but only after #1393 is merged (should be merged soon).
@badassscoder For this repo, see CONTRIBUTING.md in root of Repo. If you want to look at other repos, see the Org page here: https://github.com/kiwix/ and follow links on there. There...
Autoupdate in Electron should be blocked when `params.allowInternetAccess` is false and in Windows 7
Hmm, strange, this code should prevent Electron autoupdate from running if `params.allowInternetAccess` is false: https://github.com/kiwix/kiwix-js-pwa/blob/main/www/js/app.js#L996 As this blocks the `checkUpdateServer()` function, it should not be possible for it to run....
Autoupdate in Electron should be blocked when `params.allowInternetAccess` is false and in Windows 7
OK, strange, autoupdates are also already blocked in Win7, here: https://github.com/kiwix/kiwix-js-pwa/blob/main/www/js/app.js#L1010
Autoupdate in Electron should be blocked when `params.allowInternetAccess` is false and in Windows 7
So, this needs testing in a Win7 VM, because it appears the code is already correct.
Autoupdate in Electron should be blocked when `params.allowInternetAccess` is false and in Windows 7
So, what I believe is happening is that the user who reported this was not aware that allowing Internet access in order to open the library also lifts the block...
Autoupdate in Electron should be blocked when `params.allowInternetAccess` is false and in Windows 7
OK, it appears that the 32bit Win7 version was not being built with the correct Electron version, and because of this, the wrong executable was being provided, probably incompatible with...
Now I can't reproduce it, but it was reproducing for sure yesterday. Well, this is typical of race conditions...
This may have been fixed by fixes and checks introduced in #636 and #638. Needs monitoring.
Fixed in https://github.com/kiwix/kiwix-js-pwa/commit/23f679a62c643642316231cc171d73e2ef0dd6ce. Problem was caused by broken references to a mediawiki pcs script that we do not use or extract when overriding styles in dark mode.