acer-predator-turbo-and-rgb-keyboard-linux-module
acer-predator-turbo-and-rgb-keyboard-linux-module copied to clipboard
Refactor project structure
trafficstars
I created this project only because Linux kernel didn't accept the RGB functionality as it wasn't standard, but it got more attention than I expected. The project designed like this:
- Cloned (~2021) the
acer-wmi.cfile from Linux kernel: https://github.com/torvalds/linux/blob/master/drivers/platform/x86/acer-wmi.c - Modified the driver to support RGB and turbo
- Then on installation, the installer unload the acer driver(
acer-wmi) and installs this driver(facer)
Main issues with this approach is:
- This project doesn't receive updates from Linux kernel
- It's harder to extract parts of this code to be used in Linux kernel
For example, fan control is now in progress to be merged in Linux kernel by other people: https://github.com/JafarAkhondali/acer-predator-turbo-and-rgb-keyboard-linux-module/issues/152
But we can't use that.
There are two things we can do, as baby steps:
- Sync facer.c with https://github.com/torvalds/linux/blob/master/drivers/platform/x86/acer-wmi.c to have latest features
- Instead of cloning whole code, save the implemented features as patch files(this makes some issues with contributions but I have no other ideas how to properly stay up to date with kernel upstream for a single file).
More help is required for this part.