Jaehwa Noh

Results 34 comments of Jaehwa Noh

@SimonMarquis https://github.com/android/nowinandroid/pull/1542#pullrequestreview-2174456503 It works.

I think the bottom navigation bar location is normal, because that DeviceConfiguration had been overridden as height 400dp.

That test had been removed at #1373. If no problems found in any other tests, this issue could be closed.

There's no chance GMD to covers the lower API. https://developer.android.com/studio/test/gradle-managed-devices > This feature, available for API levels 27 and higher, I think we should remain the androidTest for lower api.

> ``` > combine(a, b) { ... } > .flowOn(defaultDispatcher) > ``` Good suggestion. I'll accept your suggestion. Thank you.

#1250 This issue had given the clue that how to solve the test fail problems when I was struggling with some tests fail. The key was single scheduler! Thanks.

This issue had been resolved at AGP 8.4.0, no longer show warning. #1434

The merged two modules, seemed too big and coarse grained to me. What about just moving `InterestListDetailScreen` and `Interests2PaneViewModel` into `:interests`?

Could you check this PR release mode onto the device or emulator? May the `@Serializable` Route be obfuscated, and makes runtime error. In this, you need to update a proguard...