사재혁
사재혁
Hi, I’ve created a PR for this issue! - https://github.com/elastic/apm-agent-python/pull/2460
> @saJaeHyukc , 사용 시나리오 Description에 추가 부탁드립니다. @soimkim 해당 부분 추가했습니다 이 부분 적용할 경우 contribute 문서도 수정하도록 하겠습니다.
@dd-jy I'm interested in this part; would it be okay if I submit a PR?
+You might also consider implementing the pre-commit hook using GitHub Actions to create a workflow.
> @saJaeHyukc 님, 추가로 PR생성시, pytest -v --flake8를 수행하도록 되어 있습니다. 중복으로 flake8 를 수행하는 것이 아닌지 문의드립니다. 해당 부분 github actions에 pre-commit으로 통합하여 검사하면 어떨까 싶습니다.
@xrmx Thank you for the review. I was going to make some other changes back then but forgot about it… I’ve now reflected everything you mentioned!
> Hi > > On a second reading, I don't think this should be a separate index class, but instead an expression/function. > > MySQL allows indexes to mix prefixes...
@adamchainz You mean that in MySQL’s [`_create_index_sql`,](https://github.com/django/django/blob/54402a75296909b1b00df41ff4dbd95e3d8a87e6/django/db/backends/base/schema.py#L1546) whenever it encounters a `Slice` expression for an index, it should emit the `column(n))` syntax instead of `SUBSTRING(col, 1, n)`, correct?
> Yes, that could be all it needs! It would need to be for slices with `start=None` and `step=None`, specifically. Thanks a lot for your feedback. I’ve opened a ticket...