Jacques Le Roux
Jacques Le Roux
`I would suggest creating a separate ticket to 'create IDE profiles for groovy styling' as we already have a lot do take care of with this ticket.` Done with https://issues.apache.org/jira/browse/OFBIZ-12764
@danwatford , it's possible conflicts related to change for https://issues.apache.org/jira/browse/OFBIZ-12793 "Cannot add a new geo point to a facility"
I changed to "passed", since indeed anyway conflicts will show and will need to be fixed.
If we suppose it's (only) about integration (GH actions and BB) we could not load the plugins when checking?
I was actually wondering if Codenarc was providing threshold, according to* it is. * https://stackoverflow.com/questions/27949345/codenarc-priority-meanings
Hi @mbrohl, should we close?
Else, as it's a very simple change we can also do it manually and backport...
Seems that it's too late ``` C:\projectsASF\Git\ofbiz-framework>git checkout -b CharlesNereide-seo-improvements trunk Switched to a new branch 'CharlesNereide-seo-improvements' C:\projectsASF\Git\ofbiz-framework>git pull https://github.com/CharlesNereide/ofbiz-framework.git seo-improvements From https://github.com/CharlesNereide/ofbiz-framework * branch seo-improvements -> FETCH_HEAD Auto-merging applications/product/src/main/java/org/apache/ofbiz/product/category/ftl/CatalogUrlSeoTransform.java...
I totally agree. I tried to follow GH advice but it's really too late. It's a mess impossible to fix but if we are able to merge CatalogUrlSeoTransform.java, not an...
Note that it can still be reopened...