JacquesCarette
Type system issues
PDController has type errors in the differential model system. The process variable is defined as a vector but the equations mix scalar and vector operations. Need guidance on whether this should be a single higher-order ODE or a proper first-order system representation.
SWHS thermal model has temperature variables defined as vectors but used as functions of time in expressions like apply1 tempW time. Should these be redefined as proper time-dependent functions or should the expressions be simplified to use them as scalars?
SSP has type mismatches where vector quantities (like water force) are compared with scalars in equality expressions. Need to determine if these should be component-wise comparisons, magnitude comparisons, or if the vector types should be changed to scalars?
GamePhysics has type inconsistencies mixing Real/Integer/Rational types and improper vector operations. Needs systematic review to ensure mathematical expressions match the physical quantity types being modeled.
Several examples have symbol duplication warnings where the same symbol is inserted multiple times in the SymbolMap. This suggests either redundant definitions or improper symbol management. Should we clean these up or are they expected?
@JacquesCarette and @balacij might see something in your list that is easy to fix, and thus worth the effort, but my instinct is to not expand the scope of your work. Let's get the double pendulum example done before looking for other problems. :smile:
PDController has type errors in the differential model system. The process variable is defined as a vector but the equations mix scalar and vector operations. Need guidance on whether this should be a single higher-order ODE or a proper first-order system representation.
SWHS thermal model has temperature variables defined as vectors but used as functions of time in expressions like apply1 tempW time. Should these be redefined as proper time-dependent functions or should the expressions be simplified to use them as scalars?
SSP has type mismatches where vector quantities (like water force) are compared with scalars in equality expressions. Need to determine if these should be component-wise comparisons, magnitude comparisons, or if the vector types should be changed to scalars?
GamePhysics has type inconsistencies mixing Real/Integer/Rational types and improper vector operations. Needs systematic review to ensure mathematical expressions match the physical quantity types being modeled.
A lot of the type checking issues are known and documented on the issue tracker. If you search for "type error", you can try having a look at them individually and trying to fix them. I imagine going by case study (as you suggest) is a good idea. Unfortunately, all of them require some amount of exploratory work, especially because we import some quantities from drasil-data and use them slightly differently in all of the examples.
Several examples have symbol duplication warnings where the same symbol is inserted multiple times in the SymbolMap. This suggests either redundant definitions or improper symbol management. Should we clean these up or are they expected?
Make sure to pull in main. A lot of these should be resolved already by Jack's work, and I'll be having a look at the remaining ones shortly. This issue is relevant to #2873.
