Drasil icon indicating copy to clipboard operation
Drasil copied to clipboard

Renamed UncertainChunk to Uncertain

Open NoahCardoso opened this issue 9 months ago • 3 comments

I renamed the UncertainChunk datatype to just Uncertain as part of the renaming chunks named in the form "XChunk" as just "X". Contributes to #3244

NoahCardoso avatar May 08 '24 17:05 NoahCardoso

Based on @JacquesCarette's comment, since "Uncertain" is also an adjective, we may want to think of another name for these chunks as well. Perhaps investigating the difference between UncertainChunk and UncertQ would help shed some light on this!

samm82 avatar May 08 '24 18:05 samm82

@samm82 would changing UncertainChunk to Uncertainty be better? Also do you want all of the Chunks to be nouns? I changed ParameterChunk to Param, UnitalChunk to Unital, UnitaryChunk to Unit, and CodeChunk to Code.

NoahCardoso avatar May 09 '24 15:05 NoahCardoso

Now is our opportunity to think a bit deeper: UncertainChunk is the encoding of a ConstrainedChunk that adds an uncertainty field to it. It isn't "an uncertainty".

The problem with coming up with a good name for it is that it is likely to require coming up with a new better name for ConstrainedChunk first!

So there's a bigger issue (which you should probably get @samm82 and @balacij help you draft) about naming all things derived from Quantity.

JacquesCarette avatar May 09 '24 21:05 JacquesCarette

This pr is no longer relevant and should be deleted

NoahCardoso avatar Jun 20 '24 15:06 NoahCardoso