Drasil icon indicating copy to clipboard operation
Drasil copied to clipboard

Chapter 3 External Libraries - MEng Report

Open cd155 opened this issue 2 years ago • 3 comments

Chapter 3 External Libraries is ready for review.

pdf file: https://github.com/JacquesCarette/Drasil/blob/dongFixWhenWritting/People/Dong/report/templates/Thesis_Main.pdf

tex file: https://github.com/JacquesCarette/Drasil/blob/dongFixWhenWritting/People/Dong/report/templates/chapter3.tex

last commit e3bebb64e01b2a290bfbe6a0dfb37e54d728b6a2

With regard to using the commit to highlight the change I made, so I can get feedback after editing. I usually have a couple of commits for one feedback, so I wasn't sure which commit should I use. @smiths

cd155 avatar Jul 26 '22 18:07 cd155

I'll have a look at Chapter 3 soon. As far as which commits to highlight the changes, you just list them all. :-)

smiths avatar Jul 28 '22 14:07 smiths

Feedback on Chapter 3 is available in cb47623de.

For adding output type information to Chapter 3, as mentioned in my comments on the pdf, I suggest you look at the MIS for the ODE Solver module for the SWHS example.

smiths avatar Jul 28 '22 14:07 smiths

Do indicate when this feedback has been incorporated, I can look at Chapter 3 after that.

JacquesCarette avatar Aug 02 '22 11:08 JacquesCarette

I made some changes based on Dr.Smith's feedback, so it is ready for review. @JacquesCarette The original PDF link should reflect changes.

last commit 10f04e0e0e0612b99dfab2e8f32250ec40b558ad

cd155 avatar Aug 08 '22 16:08 cd155

@smiths The 3.3 Output an ODE is the section I made significant changes. Some specifications were inspired by MIS for the ODE Solver module for the SWHS example. Suggestions on this section would be really appreciated.

cd155 avatar Aug 31 '22 16:08 cd155

@cd155 my feedback on Section 3.3 is available in 5df25558b. I'm suggesting introducing a possibly unusual notation for an infinite sequence. When Jacques reviews your work, he may know a better notation. For now though, lets go with my idea. :smile:

smiths avatar Sep 01 '22 14:09 smiths