Drasil icon indicating copy to clipboard operation
Drasil copied to clipboard

Choices internal concept

Open peter-michalski opened this issue 2 years ago • 3 comments

PR for removing some duplicate Strings. In https://github.com/JacquesCarette/Drasil/commit/c53be7b26a466e3a569589201d80a1a77ba31378 I set up the InternalConcepts in an associative list of (InternalConcept, Name) as part of the Choices record syntax.This provides some ground work for allowing the user to choose their own function names.

peter-michalski avatar Apr 22 '22 15:04 peter-michalski

HLint is causing problems for this, but it looks like a separate issue.

EDIT: I created #2969, it fixes the HLint problem locally, and I haven't waited yet to make sure it works on the Actions run, but if you want, you can merge #2969 in to your remote branch to also get the fix here.

balacij avatar Apr 26 '22 16:04 balacij

HLint is causing problems for this, but it looks like a separate issue.

EDIT: I created #2969, it fixes the HLint problem locally, and I haven't waited yet to make sure it works on the Actions run, but if you want, you can merge #2969 in to your remote branch to also get the fix here.

Thanks for this. The checks of this PR have now passed.

peter-michalski avatar Apr 29 '22 18:04 peter-michalski

@JacquesCarette Could you please provide feedback on this PR and comment if anything else is needed for approval?

peter-michalski avatar May 09 '22 18:05 peter-michalski

@hrzhuang could you try to take over this PR please?

JacquesCarette avatar Aug 15 '23 20:08 JacquesCarette

I continue this in #3642 since I cannot push to @peter-michalski's fork.

hrzhuang avatar Aug 17 '23 20:08 hrzhuang

Once you've 'mined' this, do close this PR please.

JacquesCarette avatar Aug 17 '23 21:08 JacquesCarette

Closing this PR now since work is continuing in #3642.

hrzhuang avatar Aug 18 '23 21:08 hrzhuang