Drasil
Drasil copied to clipboard
Choices internal concept
PR for removing some duplicate Strings. In https://github.com/JacquesCarette/Drasil/commit/c53be7b26a466e3a569589201d80a1a77ba31378 I set up the InternalConcepts in an associative list of (InternalConcept, Name) as part of the Choices record syntax.This provides some ground work for allowing the user to choose their own function names.
HLint is causing problems for this, but it looks like a separate issue.
EDIT: I created #2969, it fixes the HLint problem locally, and I haven't waited yet to make sure it works on the Actions run, but if you want, you can merge #2969 in to your remote branch to also get the fix here.
HLint is causing problems for this, but it looks like a separate issue.
EDIT: I created #2969, it fixes the HLint problem locally, and I haven't waited yet to make sure it works on the Actions run, but if you want, you can merge #2969 in to your remote branch to also get the fix here.
Thanks for this. The checks of this PR have now passed.
@JacquesCarette Could you please provide feedback on this PR and comment if anything else is needed for approval?
@hrzhuang could you try to take over this PR please?
I continue this in #3642 since I cannot push to @peter-michalski's fork.
Once you've 'mined' this, do close this PR please.
Closing this PR now since work is continuing in #3642.