Drasil icon indicating copy to clipboard operation
Drasil copied to clipboard

Duplicate References to Models in Examples

Open Ant13731 opened this issue 3 years ago • 3 comments

I think this may be the result of how the recipes are made, but the logs I'm working on (in #2759) showed some duplicate references using the angular displacement instance model in dblpendulum under the requirements section: image The first statement should probably be grouped so that the two variables are listed as

θ and θ_p (from IM:calOfAngularDisplacement)

and the second statement should not reference the same variable from the same instance model twice.

Ant13731 avatar Aug 09 '21 15:08 Ant13731

Keeping this issue open to make sure we check for other occurrences of things like this.

Ant13731 avatar Aug 10 '21 18:08 Ant13731

Yes, it would be nice to at least identify if there are other such occurrences and make issues.

JacquesCarette avatar Aug 17 '21 18:08 JacquesCarette

It seems that most of the duplicate occurrences of chunks in the logs are a result of models and definitions referring to the same thing in more than one place (ex. gamephysics' IM:transMot references DD:linAcc twice: once in the Notes section and once in the derivation). This isn't necessarily wrong, but could be improved by completing #1206, and making the description field included references for symbols (as in https://github.com/JacquesCarette/Drasil/issues/1050#issuecomment-441059933).

Edit: This also appears in NoPCM, where τ_W is referenced in the notes: image And in the derivation: image

I don't think this is a bad thing, as it gives the user more information about τ_W in the places where it is used.

Ant13731 avatar Aug 20 '21 14:08 Ant13731