Reviewing Projectile

[JacquesCarette]

(bottom up, i.e. from files with fewest dependencies first)

• Concepts
  • why is projectileTitle defined here? It's not really a 'Concept' in the same sense as the others.
  • why does projectileTitle have concept domain physics? The concept should be that of the idea. The overall domain of the document likely belongs elsewhere
  • there's comment about launch being used as an adjective that should be followed-up on.
• References
  • there is duplication (author)
  • we should probably have combinators for Wikipedia addresses
  • hmm, should the words "Acceleration" and "Velocity" be repeated here?
  • it is odd that citations here is defined "globally", so that imports from other places are here (cartesianWiki).
  • in facts citations should probably not exist, as it should be gathered from the document itself.
• Assumptions
  • (S "from" +:+ makeRef2S _) is repeated, with _ changing
  • quite a few of the assumptions are "mathematical" and could have been (also?) equations
• TMods
  • the words "acceleration" and "velocity" are repeated
  • the models should be equational (later)
  • theory models with that many empty/blank things should probably have their own constructor
• Figures
  • the path that includes 3 ".." feels... fragile.
  • (not just here, but in a lot of places, S "The" +:+ recurs)
• Unitals
  • lots of lists defined here that don't belong
  • some lists defined here that should be grabbed from the model itself
  • why is message an output? a Quantity ? a Unital even!
  • uq with default needed
  • lots of repeated wordes in the ConstrConcept definitions
  • why is unitHelper defined here of all places?
  • a lot of the ConceptChunks are English translations of something more meaningful. It would be good to capture the meaning instead.
• DataDefs
  • magNote is mostly an English translation of an equation...
  • speedRef and figRef should somehow not be so manually constructed.

[JacquesCarette]

commit 391bc4e59 removes the adjective comment from Concepts. In "launch angle" and "launch speed", "launch" is not an adjective, but still a noun. For example, "projectile angle" and "projectile speed" have the same parts-of-speech, and more clearly illustrate the decomposition.

[JacquesCarette]

Deal with Reference author duplication in 78ddc6d30.

[JacquesCarette]

from issue in Assumptions fixed in e5339acdd.

[JacquesCarette]

In a whole sequence of commits, TMods was made obsolete, as all its contents are in drasil-data now. The encoding is not perfect, but it's better than it was. So Projective is a bit smaller now - a good thing.

[JacquesCarette]

Fix the issue in Figures in d3cd663cf.

[JacquesCarette]

A bunch of concepts were defined in Unitals rather than Concepts - bb04a1e83 corrects that.

[balacij]

We should probably verify what work needs to be done, but it seems like @JacquesCarette got to a lot of it.

[samm82]

In "launch angle" and "launch speed", "launch" is not an adjective, but still a noun.

TIL that nouns used in the place of adjectives ("adjectival nouns") are actually still nouns and not adjectives! (source)