Jacob Coffee
Jacob Coffee
Sonar issues will need fixing https://sonarcloud.io/project/issues?resolved=false&severities=MAJOR&sinceLeakPeriod=true&pullRequest=2906&id=litestar-org_litestar
Seems like the remaining sonar issues revolve around code smells from the base PR and testing (TBD first in #2893)
Noticing that RapiDoc has no customizable CSS url yet. May want to add that in to #2893 alongside what was added in [7c6cc9e](https://github.com/litestar-org/litestar/pull/2906/commits/7c6cc9e6e44de60ccbe47b7d1fb2590b80b717fd)
Just waiting on the `openapi-router` work or maybe this could be merged as is now and worked on alongside the rest of the stuff (@peterschutt ?)
Using the provided MCVE I don't seem to be able to reproduce :\ ``` ~ via 🐋 colima via pyenv ➜ ntp -v 3047 Directory /tmp/testing/3047 created and switched...
lgtm besides on nit, maybe. Thanks for the contribution! 😄 Happy to see more from you if you have time/wish.
We will need to update our `conf.py` with links to target languages - https://www.sphinx-doc.org/en/master/usage/advanced/intl.html#translating-with-sphinx-intl - https://pydata-sphinx-theme.readthedocs.io/en/stable/community/topics/i18n.html - https://docs.readthedocs.io/en/stable/guides/manage-translations-sphinx.html I don't think this is super maintainable without some type of automation,...
Looking at various projects, I do not think they manually translate things except core messages? For instance sphinx-doc itself only has one language of any count, Tamil at 99%, but...
https://github.com/sphinx-doc/sphinx/blob/master/.github/workflows/transifex.yml may help