(Better) Vim support

[OscarGodson]

I love it, just wish it worked with Vim!

[ColemanGariety]

Vim is next on the agenda!

[plapier]

I'd love to see this for vim too. I'll be watching for it.

[OscarGodson]

[ColemanGariety]

Pro tip: I'll be more encouraged to work on it if you both share and star! Thanks!

[samflores]

Looking forward for it :heart:

[jamesaanderson]

:+1:

[ColemanGariety]

@jamesaanderson @samflores @plapier @OscarGodson The Vim theme is out, grab it here: http://toychesttheme.com

[OscarGodson]

Will try it out right now!

[OscarGodson]

Hmm, the colors don't look right :\

These look totally different than the other themes:

Compared to iterm:

It'd also be helpful to suggest colors because, for example, the highlighted line appears to be just an underline? The other themes set the current line to a dark blue. I took a look at the Vim theme and it looks like a lot of things aren't set at all (cursor, cursorline, etc)

[ColemanGariety]

Interesting. Mine doesn't look like that.

Are you in Terminal or MacVim?

~ Jackson Gariety

Code is poetry. http://jacksongariety.com/ @JacksonGariety

On May 8, 2013, at 2:16 PM, Oscar Godson [email protected] wrote:

Hmm, the colors don't look right :\

These look totally different than the other themes:

Compared to iterm:

It'd also be helpful to suggest colors because, for example, the highlighted line appears to be just an underline? The other themes set the current line to a dark blue. I took a look at the Vim theme and it looks like a lot of things aren't set at all (cursor, cursorline, etc)

— Reply to this email directly or view it on GitHub.

[OscarGodson]

iTerm running the MacVim executable. In my .bash_profile

alias vim='/Applications/MacVim.app/Contents/MacOS/Vim'

[OscarGodson]

Same issue if I remove that line tho. I downloaded MacVim and the issue isn't in MacVim. Only normal Vim in iTerm and Terminal.

[samflores]

changing the line 41 from

hi Normal guifg=#34d58e guibg=#2f475d guisp=#2f475d gui=NONE ctermfg=79 ctermbg=23 cterm=NONE

to

hi Normal guifg=#34d58e guibg=#2f475d guisp=#2f475d gui=NONE ctermfg=79 ctermbg=NONE cterm=NONE

will make it closer to what it should be. (Assuming you're using the iTerm theme)

[ColemanGariety]

Must be the cterm settings. If it only occurs in terminal and iTerm then it's because it's restricted to 256 colors.

I'm not sure it's possible to get it looking right through vim configuration, but I'll take a look. You can also enable the desert theme and then add the iTerm or Terminal theme.

~ Jackson Gariety

Code is poetry. http://jacksongariety.com/ @JacksonGariety

On May 8, 2013, at 2:25 PM, Oscar Godson [email protected] wrote:

Same issue if I remove that line tho. I downloaded MacVim and the issue isn't in MacVim. Only normal Vim in iTerm and Terminal.

— Reply to this email directly or view it on GitHub.

[ColemanGariety]

@samflores, you should submit your change as a pull request. I'd do it but I'm on my phone.

[wolves]

First let me thank you for an outstanding colorscheme.

I know that this issue has been closed, but I just wanted to note that setting the vimrc colorscheme to solarized with contrast set to "low" and then using the toychest iterm color palette seems to allow the terminal vim colors to display properly for the toychest theme.

I am new to vim colorschemes but thought this may help inform some changes that could be made to the default toychest.vim theme to have it appear properly within terminal vim, without having to use this work around.

[ColemanGariety]

Thanks, @aleatorik!

A vim theme itself can't modify .vimrc, so the solution needs to come from the other direction.

Ideaz?

[majjoha]

I am looking forward to a fix on this. Your theme looks great, I think!