Liang Gong

Results 52 comments of Liang Gong

Thanks for bringing this issues to our attention. At the moment, `__filename` and `__dirname` are used in several places in MemLab's code to make it easy to sync MemLab's codebase...

@doteric I was suggesting something like this as a short term solution. ```bash esbuild test.js --bundle --format=esm --define:__filename=\"./actual-filename.js\" --outfile=bundle.js ``` I'm still trying to understand how you use MemLab in...

No. I was trying to report the potential security issue mentioned above. Not sure if this is the right place since it hasn't been updated since a few months ago.

I see. Thanks for letting me know.

@singh-sp It is probably because your `retainerReferenceFilter` callback returned `true` for edges that shouldn't be used. For example, self-referencing edges cause infinite loop when traversing from a node to the...

@singh-sp `retainerReferenceFilter` is exposed as an API so that you can override the edge filter used by the retainer trace generator. Edges returned as `false` by `retainerReferenceFilter` won't be used...

> By providing a custom retainerReferenceFilter, are users overriding any default behaviors? (other than what you mentioned) It will also affect the retainer size calculation and dominator calculation: https://developer.chrome.com/docs/devtools/memory-problems/get-started

> I plan to use this filter to exclude certain edges (false positive leaks). If the edges your filter excluded were the edge that must go through from the GC...