vector-bot icon indicating copy to clipboard operation
vector-bot copied to clipboard

index: remove star imports in favor of explicit method imports

Open bdotsamir opened this issue 3 years ago • 3 comments

image image

cleans up a bunch from the transpiled code :+1:

bdotsamir avatar Jun 21 '22 02:06 bdotsamir

star imports are really only good when you wanna import a lot, or when the module doesnt properly export its methods. also it looks cleaner lol

bdotsamir avatar Jun 21 '22 02:06 bdotsamir

i realize this is the much better approach to module imports but is it rly necessary this early into development? i feel like it's a lot easier and faster to use star imports rn, especially when we dont 100% know what we will/wont be using when building foundational scripts like this.

sharkaccino avatar Jun 21 '22 04:06 sharkaccino

we can always add/remove imports later 🤷‍♂️ also good habit to have i guess.

whatever's good with you. that's why this is a pr- i knew you'd wanna say something about it

bdotsamir avatar Jun 21 '22 04:06 bdotsamir