vector-bot icon indicating copy to clipboard operation
vector-bot copied to clipboard

Move away from node-fetch

Open bdotsamir opened this issue 3 years ago • 5 comments

Node 18 now has support for the browser fetch() method. It's also an LTS release, so we can rely on there being plenty of bug fixes and backported features for years to come.

bdotsamir avatar Jun 04 '22 19:06 bdotsamir

I just tested all of the 4 cases of fetch that the bot uses and it's just as easy as removing the node-fetch package

RobertRR11 avatar Jun 04 '22 20:06 RobertRR11

Sweet, ty. The current plan is to finish up #4- jack and I are on a call rn- then we'll tackle this one. But it's good to know that removing the node-fetch package is all it takes

bdotsamir avatar Jun 04 '22 20:06 bdotsamir

I just tested all of the 4 cases of fetch that the bot uses and it's just as easy as removing the node-fetch package

lol that's what i figured x)

sharkaccino avatar Jun 04 '22 20:06 sharkaccino

jack and I are on a call rn

@RobertRR11 if you wanna join the call by any chance lmk

sharkaccino avatar Jun 04 '22 20:06 sharkaccino

sure @JackDotJS

RobertRR11 avatar Jun 04 '22 20:06 RobertRR11