Deepnest icon indicating copy to clipboard operation
Deepnest copied to clipboard

Added logic to import multiple files when prompted (fixes issues #31)

Open jsmwoolf opened this issue 6 years ago • 10 comments

Fixes #31

jsmwoolf avatar Nov 27 '18 05:11 jsmwoolf

Hopefully, this should improve readability a bit with processing the file. I did two other things:

  1. Since the code doesn't use the arrow function syntax, I decided to keep it consistent with the rest of the code.
  2. I relocated the importbutton.className to before and after the end loop. I removed them from the main logic since the current code only took into account one file. It would be best for the button to unlock after all files have been processed.

jsmwoolf avatar Nov 27 '18 05:11 jsmwoolf

Looks good to me :) (I have not tested this though)

deece avatar Nov 27 '18 05:11 deece

@deece,

Thanks for taking a look at it. Any idea who has permission to merge? I noticed that there's only one merge from August.

jsmwoolf avatar Nov 27 '18 06:11 jsmwoolf

AFAIK only @Jack000 can merge them

deece avatar Nov 27 '18 06:11 deece

should we start a development branch somewhere until jack returns?

dorkmo avatar Nov 27 '18 23:11 dorkmo

I'm in favour of that, without it, projects become abandonware. I'm just about to to the same on GerberTools.

Just make sure you add a new issue to point people to where the new code is.

deece avatar Nov 27 '18 23:11 deece

Is jack also @bmtm ?

dorkmo avatar Nov 27 '18 23:11 dorkmo

Not directly related to the PS. Is there anyword on creating the development branch? It seems like there is other bugs out there that would benefit from this if we are unable to get things merged into master.

zaped212 avatar Dec 31 '18 07:12 zaped212

Hi @zaped212,

The idea was in favor. However, I'm not aware of any branch being created at the moment. @deece, would one have to fork from this project or is there a way to add a development branch onto this repository?

jsmwoolf avatar Dec 31 '18 19:12 jsmwoolf

I'll review & merge PRs on my fork until @Jack000 is available: https://github.com/InfernoEmbedded/Deepnest

deece avatar Jan 01 '19 02:01 deece