jabref icon indicating copy to clipboard operation
jabref copied to clipboard

File field in General Tab of entry editor not adhering to dark theme

Open ThiloteE opened this issue 3 years ago • 4 comments

Newest Development version (5.8, Linux Mint (Cinnamon)) as of from just now:

grafik

Refs https://github.com/JabRef/jabref/pull/9114

ThiloteE avatar Sep 02 '22 14:09 ThiloteE

I'm interested in contributing to this issue, so before I start working it, would you mind sparing your time explaining what the fix will be like and pointing me to some resources to get started.

sreenath-tm avatar Sep 04 '22 06:09 sreenath-tm

@sreenath-tm Welcome to JabRef. First step would be to look into https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.html

For some information on Themes: https://docs.jabref.org/advanced/custom-themes Basically, the Dark.css inherits from the Light.css and overwrites the color. So you need to set a different color for this textfield /highlight

Siedlerchr avatar Sep 04 '22 09:09 Siedlerchr

I too am interested and started yesterday to get my environment setup, thank you for the guide! I am having an error that I haven't found a workaround to yet. My build is successful, but when I try to run in windows cmd prompt using .\gradlew run I get an error:

`> Configure project : Project : => 'org.jabref' Java module

Task :run 2022-09-04 19:48:29 [JavaFX Application Thread] org.jabref.logic.net.ssl.TrustStoreManager.createTruststoreFileIfNotExist() INFO: Trust store path: C:\Users\John\AppData\Local\org.jabref\JabRef\ssl\truststore.jks 2022-09-04 19:48:29 [JavaFX Application Thread] org.jabref.gui.JabRefMain.start() ERROR: Unexpected exception: java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because "originalDirectory" is null at [email protected]/org.jabref.preferences.JabRefPreferences.determineMainFileDirectory(JabRefPreferences.java:2174) at [email protected]/org.jabref.preferences.JabRefPreferences.getFilePreferences(JabRefPreferences.java:2189) at [email protected]/org.jabref.preferences.JabRefPreferences.getFileLinkPreferences(JabRefPreferences.java:1110) at [email protected]/org.jabref.preferences.JabRefPreferences.getLayoutFormatterPreferences(JabRefPreferences.java:1123) at [email protected]/org.jabref.preferences.JabRefPreferences.getCustomExportFormats(JabRefPreferences.java:2293) at [email protected]/org.jabref.gui.JabRefMain.applyPreferences(JabRefMain.java:175) at [email protected]/org.jabref.gui.JabRefMain.start(JabRefMain.java:106) at [email protected]/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:847) at [email protected]/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:484) at [email protected]/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at [email protected]/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456) at [email protected]/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96) at [email protected]/com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at [email protected]/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184) at java.base/java.lang.Thread.run(Thread.java:833)

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.`

Any assistance would be greatly appreciated!

@sreenath-tm - would you care to collaborate? I have to complete this for a school assignment.

John-Poulos avatar Sep 04 '22 23:09 John-Poulos

@John-Poulos that issue has been fixed now, you may need to update/sync your fork

Siedlerchr avatar Sep 05 '22 06:09 Siedlerchr

I'm looking to contribute, can you assign this issue to me, please?

NamanHimmatramka avatar Oct 05 '22 08:10 NamanHimmatramka

Usually I would say first come, first served, but since both @John-Poulos and @sreenath-tm seem to not have created a pull-request within the last month and also have not voiced opposing views towards the request of NamanHimmatramka, I assume they have given up and will assign this to @NamanHimmatramka

ThiloteE avatar Oct 09 '22 13:10 ThiloteE

closing this issue in favour of #9340, which is a duplicate issue, but well explained.

I assume @NamanHimmatramka has chosen a different project to work on as well.

ThiloteE avatar Nov 03 '22 00:11 ThiloteE