jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Improve entry merge dialog (3-way merge)

Open tobiasdiez opened this issue 5 years ago • 10 comments

  • [ ] Add option to show only differences
  • [ ] Emphasize header (e.g. bold and with different background) as in
  • [ ] Concert to 3-way merge: the two entries to be merged on the left and right, in the mid the final merged entry. The values of the merged entry in the center should be editable (i.e. text fields). Similar to
    • Further Inspiration:
      • - http://baymard.com/ecommerce-product-lists/benchmark/page-types/comparison-tool

tobiasdiez avatar Mar 27 '20 22:03 tobiasdiez

Should also support to merge keywords and groups (see https://github.com/koppor/jabref/issues/12).

koppor avatar Sep 02 '20 23:09 koppor

Request fromt he forum: Should support merging of files. E.g. when I merge two entries with files attached create one entry with both files.

Siedlerchr avatar Mar 24 '21 19:03 Siedlerchr

Current state: https://docs.jabref.org/finding-sorting-and-cleaning-entries/mergeentries

The main issue is that we do not show the result in the dialog

grafik

koppor avatar Jul 14 '21 20:07 koppor

When working on that, one could also solve https://github.com/JabRef/jabref/issues/2961 (see especially https://github.com/JabRef/jabref/issues/2961#issuecomment-880164801).

koppor avatar Jul 14 '21 20:07 koppor

Something similar to here https://github.com/JabRef/jabref/pull/7929

calixtus avatar Sep 22 '21 21:09 calixtus

The code bases can be https://github.com/iazarny/gitember. Deep link: https://github.com/iazarny/gitember/blob/master/src/main/java/com/az/gitember/controller/MergeDialog.java

Note that we MUST NOT copy and paste the code, because their license is Apache 2.0, whereas our license is MIT. The code cannot be relicensed without agreement from the original authors (which we don't have).

koppor avatar Mar 28 '22 18:03 koppor

Hello Team, we are group of 5 people(@Beingmani , @yogeshvar, @Rifat951, @LIM0000, @tirthvyas-tk-labs) from University of Adelaide.We are new to this community and want to start contributing to jabref. Therefore, would like to work on this specific issue. Is there any prerequisite before we start working on this issue ?

Rifat951 avatar Mar 29 '22 01:03 Rifat951

Thank you for your interest in JabRef. Be aware that this issue is is a large GSoC proposal for about 175 dedicated estimated work hours and is no beginner project. You definitely need good knowledge of java and some decent knowledge of javafx for this issue. I really would advise you to start with a good first issue to get familiar with the jabref code base before taking this project. Please also read the developer documentation about preparing your workspace and checkstyle to avoid unnecessary setbacks during the review process of your code changes. A good practice is also to make an early wip draft pull request so we can follow your changes and tell early if we thinks it's going in the wrong direction. Feel free to use our Gitter chat for questions and have fun coding.

calixtus avatar Apr 03 '22 12:04 calixtus

This should also fix #8745

Siedlerchr avatar May 01 '22 21:05 Siedlerchr

@Siedlerchr not sure, as #8745 is not about the user, but about the import logic, as far as I can see.

claell avatar May 01 '22 21:05 claell

@HoussemNasri Just stumbled across this issue? I think we can close this?

Siedlerchr avatar Oct 07 '22 18:10 Siedlerchr

https://github.com/JabRef/jabref/wiki/GSoC-2022-%E2%80%94-Implement-a-Three-Way-Merge-UI-for-merging-BibTeX-entries

HoussemNasri avatar Oct 07 '22 18:10 HoussemNasri