jabref icon indicating copy to clipboard operation
jabref copied to clipboard

feat(docs): add ADR for DI

Open InAnYan opened this issue 3 weeks ago • 4 comments

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/590

Just added an ADR.

Steps to test

No steps to test. Just check the contents.

Mandatory checks

  • [x] I own the copyright of the code submitted and I license it under the MIT license
  • [x] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [x] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

InAnYan avatar Nov 30 '25 11:11 InAnYan

You modified Markdown (*.md) files and did not meet JabRef's rules for consistently formatted Markdown files. To ensure consistent styling, we have markdown-lint in place. Markdown lint's rules help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Source Code Tests" (on the left), subsection "Markdown".

jabref-machine avatar Nov 30 '25 11:11 jabref-machine

  • [ ] TODO: We use @Inject only in Views, not in ViewModels. And this again helps in testing, as ViewModel uses constructor-based DI

InAnYan avatar Nov 30 '25 14:11 InAnYan

  • [ ] TODO @Inject for JAX-RS services - there, we use jakarta.inject.Inject and hk2: org.glassfish.hk2.api.ServiceLocator

koppor avatar Dec 01 '25 18:12 koppor

https://github.com/dlsc-software-consulting-gmbh/FxmlKit

calixtus avatar Dec 10 '25 18:12 calixtus