jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Adding reset functionality for column preferences

Open Rocker810 opened this issue 4 weeks ago • 6 comments

Closes #14414

This PR adds a reset functionality for column preferences in the entry table settings. When users override the clear() method in preferences, it now properly resets both the main table preferences and column preferences to their default values.

Changes Made:

Added getDefault() static method to ColumnPreferences class to return default column configuration
Overrode clear() method in JabRefGuiPreferences to reset main table and column preferences to defaults
Ensures that when preferences are cleared, the entry table columns are restored to their original state

Mandatory checks

  • [x] I own the copyright of the code submitted and I license it under the MIT license
  • [x] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Rocker810 avatar Nov 27 '25 06:11 Rocker810

Please do not close prs and open new ones. You can just push to your remote branch. GitHub will handle everything else. But by reopening a new pr the reviewers will loose context. That makes the process complicated, slower and more annoying.

calixtus avatar Nov 27 '25 07:11 calixtus

@calixtus Thank you for the guidance, I am sorry for the confusion caused. This is my first PR, and I was seeing how the process works. I accidentally closed it while exploring the interface.

Rocker810 avatar Nov 27 '25 07:11 Rocker810

No problem, we are here to help. Only condition is that people really try to do their best and not let ai do the talking or the coding, because JabRefs mission is to educate people about coding and open source.

calixtus avatar Nov 27 '25 11:11 calixtus

Thank you @calixtus , are there any other changes i need to do for this pr.

Rocker810 avatar Nov 27 '25 19:11 Rocker810

Your pull request modified git submodules.

Please follow our FAQ on submodules to fix.

jabref-machine avatar Dec 02 '25 00:12 jabref-machine

No. I don't think that you understood the assignment. Target is to get rid of the defaults map. Your last commit won't work at all.

This issue is not just about coding some simple hacks. You need to adapt the generic getColums methods.

calixtus avatar Dec 02 '25 06:12 calixtus

Lets give someone else a chance on this, you ignored important comments from our bots two weeks ago. https://github.com/JabRef/jabref/pull/14444#issuecomment-3599601578

calixtus avatar Dec 12 '25 14:12 calixtus

This pull requests was closed without merging. You have been unassigned from the respective issue #14414.

github-actions[bot] avatar Dec 12 '25 14:12 github-actions[bot]