jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Fix resetting of entry editor prefs

Open HamzehAdawi opened this issue 1 month ago • 4 comments

Closes #14401

This PR fixes the "Enable resetting of EntryEditorPreferences" issue.

Steps to test

Mandatory checks

  • [x] I own the copyright of the code submitted and I license it under the MIT license
  • [x] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

HamzehAdawi avatar Nov 25 '25 04:11 HamzehAdawi

Hey @HamzehAdawi!

Thank you for contributing to JabRef! Your help is truly appreciated :heart:

We have automated checks in place, based on which you will soon get feedback if any of them are failing. In a while, maintainers will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

github-actions[bot] avatar Nov 25 '25 04:11 github-actions[bot]

Try to use less AI and check your commits before pushing them. There are really sloppy mistakes that could be easily avoided by reading the code instead of just running an agent. Open source is not about writing the most code, but understand it and maybe also learn a little bit.

Please fix the mistakes.

calixtus avatar Nov 25 '25 21:11 calixtus

Removed the redundant methods and fixed EntryEditorPreferences, as requested. Please let me know if any additional changes are needed, sorry for the oversight.

HamzehAdawi avatar Nov 25 '25 23:11 HamzehAdawi

Moved EntryEditorPref constants from JabRefCli to JabRefGui.

@calixtus regarding the EntryEditorTabs, I am not entirely sure if this is what you had in mind, so please let me know if anything should be adjusted there.

HamzehAdawi avatar Nov 27 '25 18:11 HamzehAdawi

This pull requests was closed without merging. You have been unassigned from the respective issue #14401.

github-actions[bot] avatar Dec 17 '25 00:12 github-actions[bot]

This should probably be continued by someone more experienced seeing that this is a "good second issue" now. Sorry could not help further.

We switched to "good second issue" because of experience in this PR. - I had slightly hopes that you could do it, but we lowered the expectations for good first issues.

koppor avatar Dec 17 '25 08:12 koppor