jabref icon indicating copy to clipboard operation
jabref copied to clipboard

feat(slr): run duplicate check after finding papers

Open InAnYan opened this issue 1 month ago • 5 comments

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/1063

Tried to run a duplicate check after SLR.

Remarks:

  • In general, this should not happen and internally SLR must remove (move, merge, treat) duplicate papers.
  • I'm not sure that the chosen approach of AutomaticDuplicateRemover is right.

Steps to test

  1. Checkout to the latest main branch
  2. Run SLR with any query (I used for testing: greek, greeks, ancient greeks)
  3. I got around 458 entries

After I run a duplicate finder with clicking "Keep merged", I got 449 entries.

Then:

  1. Checkout to this PR
  2. Run the same SLR
  3. See that you got 449 entries

Mandatory checks

  • [x] I own the copyright of the code submitted and I license it under the MIT license
  • [x] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [x] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

InAnYan avatar Nov 02 '25 18:11 InAnYan

You ticked that you modified CHANGELOG.md, but no new entry was found there.

If you made changes that are visible to the user, please add a brief description along with the issue number to the CHANGELOG.md file. If you did not, please replace the cross ([x]) by a slash ([/]) to indicate that no CHANGELOG.md entry is necessary. More details can be found in our Developer Documentation about the changelog.

jabref-machine avatar Nov 06 '25 14:11 jabref-machine

  1. There is a changelog entry
  2. I ran "reformat code" and "organize imports" on touched Java files, but nothing new

InAnYan avatar Nov 06 '25 14:11 InAnYan

For proper reviewing, I need to run the SLR for myself and debug -- is there an example with less than 10 entries maybe? 400 is too much for me to "quickly" check.

I think, the method called the line before needs to be fixed - or properly documented/understood, why there are duplicates: https://github.com/InAnYan/jabref/blob/636e4135005479325a92cc6eedbccbccf6e11a42/jablib/src/main/java/org/jabref/logic/crawler/StudyRepository.java#L420

koppor avatar Nov 21 '25 23:11 koppor

Okay, I will prepare a specific and repeatable example

InAnYan avatar Nov 22 '25 07:11 InAnYan

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

github-actions[bot] avatar Dec 01 '25 00:12 github-actions[bot]