feat(slr): run duplicate check after finding papers
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/1063
Tried to run a duplicate check after SLR.
Remarks:
- In general, this should not happen and internally SLR must remove (move, merge, treat) duplicate papers.
- I'm not sure that the chosen approach of
AutomaticDuplicateRemoveris right.
Steps to test
- Checkout to the latest main branch
- Run SLR with any query (I used for testing:
greek,greeks,ancient greeks) - I got around 458 entries
After I run a duplicate finder with clicking "Keep merged", I got 449 entries.
Then:
- Checkout to this PR
- Run the same SLR
- See that you got 449 entries
Mandatory checks
- [x] I own the copyright of the code submitted and I license it under the MIT license
- [x] I manually tested my changes in running JabRef (always required)
- [/] I added JUnit tests for changes (if applicable)
- [/] I added screenshots in the PR description (if change is visible to the user)
- [/] I described the change in
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user) - [x] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.
You ticked that you modified CHANGELOG.md, but no new entry was found there.
If you made changes that are visible to the user, please add a brief description along with the issue number to the CHANGELOG.md file. If you did not, please replace the cross ([x]) by a slash ([/]) to indicate that no CHANGELOG.md entry is necessary. More details can be found in our Developer Documentation about the changelog.
- There is a changelog entry
- I ran "reformat code" and "organize imports" on touched Java files, but nothing new
For proper reviewing, I need to run the SLR for myself and debug -- is there an example with less than 10 entries maybe? 400 is too much for me to "quickly" check.
I think, the method called the line before needs to be fixed - or properly documented/understood, why there are duplicates: https://github.com/InAnYan/jabref/blob/636e4135005479325a92cc6eedbccbccf6e11a42/jablib/src/main/java/org/jabref/logic/crawler/StudyRepository.java#L420
Okay, I will prepare a specific and repeatable example
Your pull request conflicts with the target branch.
Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.