jabref icon indicating copy to clipboard operation
jabref copied to clipboard

[depends-on-external] Update to JDK25

Open koppor opened this issue 4 months ago • 9 comments

Actions

  • [ ] Wait for JDK 25.0.2 should be available on January, 20th (https://www.java.com/releases/) -> https://github.com/corretto/corretto-25/releases

  • [ ] Merge this PR

  • [ ] Fix name of required workflows

    • new
      image
    • old
      image
  • [ ] Integrate this branch into https://github.com/JabRef/jabref/pull/13033 --> https://github.com/koppor/magic-merge-commit/

  • [ ] Merge https://github.com/JabRef/jabref/pull/13033

  • [ ] Continue at https://github.com/JabRef/jabref/pull/13937

  • [ ] Experiment: Try out OpenJ9 (see https://github.com/JabRef/jabref-koppor/pull/481) for details.

Background

Relative of https://github.com/JabRef/jabref/pull/13937. Here, we just update the JDK to version 25. Due to https://bugs.openjdk.org/browse/JDK-8358723, we need to wait for 25.0.2 - see also https://github.com/JabRef/jabref/pull/13937#issuecomment-3382663156

Steps to test

  1. Download the build binary and start - check if its running
  2. Open this branch in the IDE and check if "run" works.

Mandatory checks

  • [x] I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

koppor avatar Oct 09 '25 10:10 koppor

I switched to Temurin in .sdkmanrc as most users use that - and we need Corretto only for distribution CC @Siedlerchr

koppor avatar Oct 22 '25 14:10 koppor

openjdk version "25.0.1" 2025-10-21 LTS OpenJDK Runtime Environment Corretto-25.0.1.8.1 (build 25.0.1+8-LTS) OpenJDK 64-Bit Server VM Corretto-25.0.1.8.1 (build 25.0.1+8-LTS, mixed mode)

still crash

Siedlerchr avatar Oct 22 '25 15:10 Siedlerchr

Fix is not yet in 25.01

Siedlerchr avatar Oct 22 '25 15:10 Siedlerchr

grafik

koppor avatar Oct 22 '25 15:10 koppor

The fix resulted in JDK-8369853 regression. These two issues should be backported together

koppor avatar Oct 22 '25 15:10 koppor

Some JavaFX dependency was not available at the last build attempt:


      > Could not find javafx-base-25.0.1-linux-aarch64.jar (org.openjfx:javafx-base:25.0.1).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/25.0.1/javafx-base-25.0.1-linux-aarch64.jar

koppor avatar Nov 03 '25 07:11 koppor

Reported at https://github.com/gluonhq/openjfx-smoke-tests/issues/14

koppor avatar Nov 03 '25 11:11 koppor

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

github-actions[bot] avatar Dec 01 '25 00:12 github-actions[bot]

The build of this PR is available at https://builds.jabref.org/pull/14057/merge.

github-actions[bot] avatar Dec 17 '25 18:12 github-actions[bot]