JabRef
OCR integration
Closes #13267
In about one to three sentences, describe the changes you have made: what, where, why, ...
Steps to test
Describe how reviewers can test this fix/feature. Ideally, think of how you would guide a beginner user of Jabef to try out your change. You can add screenshots or videos (using Loom or by just adding .mp4 files).
Mandatory checks
- [x] I own the copyright of the code submitted and I license it under the MIT license
- [.] Change in
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user) - [.] Tests created for changes (if applicable)
- [.] Manually tested changed features in running JabRef (always required)
- [.] Screenshots added in PR description (if change is visible to the user)
- [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
- [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
Your pull request conflicts with the target branch.
Please merge
upstream/mainwith your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.
Tip for future - always take a fresh pull from upstream/main before beginning to work on a branch (if there has been a decent time gap).
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it.
In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push.
Just in case someone will notice sub-modules problems -- this was my fault that I brought in https://github.com/JabRef/jabref/pull/13313/commits/e4e45f3feecc86e255a3a0eb8e65f6894b2c3219
I tried to follow https://devdocs.jabref.org/code-howtos/faq.html#submodules to fix what I've done to submodules, but it didn't work
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it.
In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push.
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).
JUnit tests of jablib are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Unit tests (pull_request)" and click on it.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
Commit pushed about one hour ago. We sadly had no time to review the changes in time for the meeting.
Closing this for housekeeping. Maybe if you or sbdy else is interested in picking this up again, this can be reopened. Work is not lost, but archived. Thank you for your efforts.