jabref icon indicating copy to clipboard operation
jabref copied to clipboard
verified publisher icon JabRef

Do not show "Merge PDF metadata" dialog if there is nothing to merge

Open koppor opened this issue 10 months ago • 4 comments

  1. Create a new library
  2. Drag'n'drop jablib\build\resources\test\pdfs\minimal.pdf into it
  3. See Merge PDF metadata dialog appearing.
  4. It first shows a "Grobid" column.
    Image
  5. However, this disappears:
    Image

Expected result: Dialog closes itself after if there is only one column shown (and the user did not do any manual changes)

This is a follow-up to https://github.com/JabRef/jabref/issues/13132

It is Expection 1: "No dialog appears, because there is only one "real" source of information"

koppor avatar Jun 05 '25 07:06 koppor

/assign-me

Nathaandev avatar Jun 10 '25 21:06 Nathaandev

👋 Hey @Nathaandev, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

For questions on JabRef functionality and the code base, you can consult the JabRef Guru or ask on our Gitter chat.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

github-actions[bot] avatar Jun 10 '25 21:06 github-actions[bot]

Hello, @koppor,

I am happy to be making my second contribution to Jabref. Would you have a lead regarding this issue? I did not understand what I have to do, and the Grobid column does not appear to me when I drag the minimal.pdf.

Nathaandev avatar Jun 10 '25 21:06 Nathaandev

Hello, @koppor,

I am happy to be making my second contribution to Jabref. Would you have a lead regarding this issue? I did not understand what I have to do, and the Grobid column does not appear to me when I drag the minimal.pdf.

Please check in the running JabRef the JabRef preference if Grobid is enabled. Search for "Grobid" there.

koppor avatar Jun 11 '25 03:06 koppor

We think that this issue was fixed. Please head to https://builds.jabref.org/main to download a development build and try it out.

For any feedback, add a comment to the pull request at https://github.com/JabRef/jabref/pull/13309.

github-actions[bot] avatar Jun 19 '25 21:06 github-actions[bot]