jabref icon indicating copy to clipboard operation
jabref copied to clipboard

11219 adapt UI font size

Open harry924 opened this issue 1 year ago • 1 comments

closes https://github.com/JabRef/jabref/issues/11219 Merged all the CSS files to Base.css

converted all px units to em

Fixed toggle button and sperator padding issue

Conducted UI testing by comparing interfaces before and after changes.

Mandatory checks

  • [x] I own the copyright of the code submitted and I licence it under the MIT license
  • [ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • [ ] Tests created for changes (if applicable)
  • [x] Manually tested changed features in running JabRef (always required)
  • [x] Screenshots added in PR description (for UI changes)
  • [x] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [x] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Separator-issue

Fixed-Separator

misaligned-filter-icon

Fixed-filter-icon

harry924 avatar Oct 20 '24 11:10 harry924

then remove the unused css files as well

Siedlerchr avatar Oct 20 '24 12:10 Siedlerchr

Hi, I have deleted original individual CSS files and the BaseBackUp.css and consolidated styles into Base.css. and also updated all the relevant Java classes to reference Base.css instead of the deleted files.

harry924 avatar Oct 24 '24 11:10 harry924

The changes look good to me. However, the pull request does more than just adapt font size. For instance, the merging of all CSS styles into Base.css could be a source of regressions, so I recommend for adding multiple entries to the changelog or merge the individual commits without squash.

HoussemNasri avatar Nov 30 '24 15:11 HoussemNasri

Overall looks good, however, JabRef opens always maximized, even if I resize it and move it to the screen center but this might be another issue because I reset my prefs as well

Siedlerchr avatar Nov 30 '24 17:11 Siedlerchr

Changelog should contain a note about the effect of custom themes!

Siedlerchr avatar Nov 30 '24 17:11 Siedlerchr

@InAnYan I took the liberty to simplify the privacy component and to make it a bit more coherent to the mrdlib privacy dialog. Can you also take a look?

calixtus avatar Nov 30 '24 18:11 calixtus

grafik

calixtus avatar Dec 02 '24 21:12 calixtus

GPT4all privacy link was the same as before. Change it in another pr as this is focused on css and ui

calixtus avatar Dec 02 '24 22:12 calixtus