JabRef
Fix moving of file into library
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/630
Follow-up to #11576
Additionally:
- We added support for modifier keys when dropping a file on an entry in the main table.
- When dropping a file into the main table, after copy or move, the file is now renamed according to the configured patterns.
Mandatory checks
- [x] I own the copyright of the code submitted and I licence it under the MIT license
- [x] Change in
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable) - [ ] Tests created for changes (if applicable)
- [x] Manually tested changed features in running JabRef (always required)
- [ ] Screenshots added in PR description (for UI changes)
- [ ] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
Need to test under Mac, there was something about modifiers not working
Test is drag and drop with and without modifier keys>
- outside file directory
- inside file directory
Which means: 6 different manual test cases.
You can also add drag'n'drop from another volume, which makes then 9 test cases.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I've only done 3 test cases with a .bib file outside of the PDFs files directory.
The PR works!
(Linux Mint)
One needs to check whether the file indexing works - or causes trouble... I would bet it works, because I first handle the file on the file system and then add it to jabref which then indexes it...
Fixed compilation errors, removed IndexManager from ImportHandler, and removed the index blocker.
Tested, the indexing works without issues.
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.