jabref
jabref copied to clipboard
JabRef
Fix: re-implemented bib entry highlight when dragging and dropping files
Closes #11898 Removed a chunk of code that was overriding the background colour of bib entires when dragging and dropping a file. Initially caused by changes implemented when resolving #11579.
Mandatory checks
- [x] I own the copyright of the code submitted and I licence it under the MIT license
- [ ] Change in
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable) - [ ] Tests created for changes (if applicable)
- [x] Manually tested changed features in running JabRef (always required)
- [x] Screenshots added in PR description (for UI changes)
- [x] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
- [x] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
I am not sure that removing all the colors is really a good idea, they were implemented for the different searching options ("floating mode") with groups and without groups
Yes, this would remove the visual distinction between matching groups in floating search mode. Please reimplement the matching/non-matching colors. Highlighting must respect them. Maybe @loay can help here?
Ah that makes sense! I thought for some reason the deleted section was redundant, I'll rework it to work around the matching groups in floating search mode. Thanks for the feedback!
Link to PRs "fixing" the colors: https://github.com/JabRef/jabref/pull/11591
Yes, this would remove the visual distinction between matching groups in floating search mode. Please reimplement the matching/non-matching colors. Highlighting must respect them. Maybe @loay can help here?
I think you mentioned the wrong loay here :)
