jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Customizable AI templates

Open InAnYan opened this issue 1 year ago • 3 comments

Now, all LLM templates can be customized by users. Previously, only the system message was customizable in a limited way.

I used Apache Velocity template engine.

image image

Mandatory checks

~- [ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)~ ~- [ ] Tests created for changes (if applicable)~

InAnYan avatar Oct 06 '24 12:10 InAnYan

Side comment: This refs https://github.com/koppor/jabref/issues/392, where we first wanted Apache Velocity - but then wanted Thymeleaf (and did not want Apache FreeMarker).

koppor avatar Oct 06 '24 15:10 koppor

I think it I necessary now to finally create an ADR now for the template engine. Please create a simple one, with your decision drivers for velocity and we can fill in the others for the next dev-call to decide on it together.

I think we need to decide on it, since we should not have multiple templating engines running in favor of resources.

calixtus avatar Oct 06 '24 16:10 calixtus

I think it I necessary now to finally create an ADR now for the template engine.

Coming from https://github.com/JabRef/jabref/pull/11900, Velocity was the right choice. We need to improve the ADR itself, but it is good enough to show that this was the right choice.

koppor avatar Oct 16 '24 08:10 koppor

@InAnYan Can you resolve the conflicts? I think, then, this can go in - and https://github.com/JabRef/user-documentation/pull/519 can also be merged?

koppor avatar Oct 28 '24 13:10 koppor

Cool, the ADR is merged!

I'll fix everything, but in the evening

InAnYan avatar Oct 28 '24 13:10 InAnYan